[RFC][TIR] Change AllocateNode::extent to 1-D #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
changed the title
|
Thanks for the RFC. A quick question: RFC #39 mentioned the usage of |
|
This is the first in a series of proposed changes, and this one on its own won't be able to support the |
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Oct 22, 2021
Currently in PR at apache#9194, waiting on RFC apache/tvm-rfcs#40. Locally, this is a merge commit for the 'allocate_node_1d', to help me keep track of which commits belong in which PRs.
|
Closing this RFC, as it is no longer applicable after significant changes made to #39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC changes
Array<PrimExpr> AllocateNode::extentstoPrimExpr AllocateNode::extent, giving the 1-d size of the buffer to be allocated. This is part of the separation between logical layout and physical layout, proposed in RFC#0039.Rendered markdown link