Skip to content

Commit

Permalink
fix group_conv3d caculate error (#12500)
Browse files Browse the repository at this point in the history
  • Loading branch information
chengven027 authored Aug 19, 2022
1 parent 41be1b4 commit 9d6039b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions python/tvm/topi/x86/conv3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def _conv3d_ndhwc(cfg, data, kernel, strides, padding, dilation, groups, out_dty
# pack kernel
shape = (
num_filter // oc_bn,
in_channel // groups // ic_bn,
in_channel // groups // ic_bn if (in_channel // groups // ic_bn) else 1,
kernel_depth,
kernel_height,
kernel_width,
Expand Down Expand Up @@ -392,7 +392,7 @@ def _conv3d_ncdhw(cfg, data, kernel, strides, padding, dilation, layout, groups,
# pack kernel
shape = (
num_filter // oc_bn,
in_channel // groups // ic_bn,
in_channel // groups // ic_bn if (in_channel // groups // ic_bn) else 1,
kernel_depth,
kernel_height,
kernel_width,
Expand Down
2 changes: 1 addition & 1 deletion tests/python/frontend/onnx/test_forward.py
Original file line number Diff line number Diff line change
Expand Up @@ -2967,7 +2967,7 @@ def repeat(num, dims):
)

# TODO(jwfromm): Merge with other tests once group_conv3d is supported.
for dims in [1, 2]:
for dims in [1, 2, 3]:
# Group Convolution
verify_conv(
(1, 8) + repeat(5, dims),
Expand Down

0 comments on commit 9d6039b

Please sign in to comment.