Set dref.handle to None instead of using __del__ functions

apache · Jul 24, 2024 · d311b3d · d311b3d
1 parent f47ea06
commit d311b3d
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 14 deletions.
diff --git a/python/tvm/_ffi/_cython/ndarray.pxi b/python/tvm/_ffi/_cython/ndarray.pxi
@@ -72,9 +72,6 @@ cdef class NDArrayBase:
         def __set__(self, value):
             self._set_handle(value)
 
-        def __del__(self):
-            self.chandle = NULL
-
     property is_view:
         def __get__(self):
             return self.c_is_view != 0

diff --git a/python/tvm/_ffi/_cython/object.pxi b/python/tvm/_ffi/_cython/object.pxi
@@ -106,9 +106,6 @@ cdef class ObjectBase:
         def __set__(self, value):
             self._set_handle(value)
 
-        def __del__(self):
-            self.chandle = NULL
-
     def __dealloc__(self):
         CHECK_CALL(TVMObjectFree(self.chandle))
 

diff --git a/python/tvm/_ffi/_cython/packed_func.pxi b/python/tvm/_ffi/_cython/packed_func.pxi
@@ -308,22 +308,15 @@ cdef class PackedFuncBase:
         def __set__(self, value):
             self.c_is_global = value
 
-        def __del__(self):
-            self.c_is_global = 0
-
     property handle:
         def __get__(self):
             if self.chandle == NULL:
                 return None
             else:
                 return ctypes.cast(<unsigned long long>self.chandle, ctypes.c_void_p)
-
         def __set__(self, value):
             self._set_handle(value)
 
-        def __del__(self):
-            self.chandle = NULL
-
     def __init__(self, handle, is_global):
         self._set_handle(handle)
         self.c_is_global = is_global

diff --git a/python/tvm/runtime/disco/session.py b/python/tvm/runtime/disco/session.py
@@ -92,7 +92,7 @@ class DModule(DRef):
 
     def __init__(self, dref: DRef, session: "Session") -> None:
         self.handle = dref.handle
-        del dref.handle
+        dref.handle = None
         self.session = session
 
     def __getitem__(self, name: str) -> DPackedFunc: