Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU][6] Migrate codegen to use cascader #10377

Closed
wants to merge 2 commits into from

Conversation

mbaret
Copy link
Contributor

@mbaret mbaret commented Feb 24, 2022

RFC: apache/tvm-rfcs#37
Issue: #9429

NOTE: This PR builds on top of #10062 and therefore includes those changes. This PR will remain as 'draft' until the dependencies are merged.

Use the cascader as the default scheduler. Includes placeholder MemoryRegions until integration with the PoolInfos provided by a user.

Change-Id: I6771578f1007b8fea02e2dec7d0c797a6ef6aa5e
Use the cascader as the default scheduler. Includes
placeholder MemoryRegions until integration with the
PoolInfos provided by a user.

Change-Id: I9a8063ed56c1c5e926389dc3b217355a5ad0e3f0
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove the try-catch otherwise LGTM!

@@ -336,7 +379,10 @@ def relay_to_tir_func(ext_func: relay.Function) -> tvm.tir.PrimFunc:
# this should be a single intelligent and a composite scheduler
# that can perform scheduling based on user inputs such as
# scratch memory size.
tir_mod, const_dict = lower_to_tir(mod["main"], copy_constants())
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use relay.ext.ethos-u.options either to explicitly enable or explicitly disable the cascader.
If we think, if the feature is not stable enough, we could try a explicit enable.

Once it get matures, we could make that the default. WDYT ?

@manupak
Copy link
Contributor

manupak commented Apr 1, 2022

Closing this in favor of #10862

@manupak manupak closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants