Fix TorchScript fallback build #10556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
force-pushed
the
fix_torch
branch
3 times, most recently
from
178616f to
0576780
Compare
driazati
requested review from
zhiics,
trevor-m,
comaniac,
mbaret,
manupak,
vinx13,
tqchen,
liangfu,
areusch,
tmoreau89,
kazum,
ZihengJiang,
junrushao,
jroesch,
yzhliu,
merrymercy and
icemelon
as code owners
masahi
approved these changes
Mar 9, 2022
|
please fix the lint issue. |
|
Oh oh. Yes. I missed to git add the header - and to enable the tests. |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This was missing a header `libtorch_runtime.h`. The test in `test_libtorch_ops.py` is also currently being skipped in CI since `torch` isn't available but that's left for a follow up cc @t-vi @masahi commit-id:f8998762 Co-authored-by: driazati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing a header
libtorch_runtime.hafter #7401. The test intest_libtorch_ops.pyis also currently being skipped in CI sincetorchisn't available but that's left for a follow upcc @t-vi @masahi