[microNPU] Determine block configs using the cascader #10695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cascader needs to be able to choose the block config for operations in order to accurately model their performance. The cascader must attach the chosen block config to the te.Schedule. This is done using a pragma. The chosen block config is also added to the TIR spec. If the cascader hasn't set a block config, it defaults to the existing block config selection behaviour. Co-authored-by: Matthew Barrett <[email protected]>
lhutton1
approved these changes
Mar 22, 2022
| @@ -460,7 +460,7 @@ def pooling(x): | |||
| op = tf.nn.relu(op) | |||
| return op | |||
|
|
|||
| _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type) | |||
| _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type, print_cmm=True) | |||
There was a problem hiding this comment.
Nit: do we need to print this?
There was a problem hiding this comment.
Yeah I think it can be removed!
| @@ -14,6 +14,7 @@ | |||
| # KIND, either express or implied. See the License for the | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| from numpy.core.shape_base import block | |||
ekalda
commented
Mar 22, 2022
| @@ -460,7 +460,7 @@ def pooling(x): | |||
| op = tf.nn.relu(op) | |||
| return op | |||
|
|
|||
| _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type) | |||
| _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type, print_cmm=True) | |||
There was a problem hiding this comment.
Yeah I think it can be removed!
| @@ -14,6 +14,7 @@ | |||
| # KIND, either express or implied. See the License for the | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| from numpy.core.shape_base import block | |||
|
Sure :) |
|
Thanks @mbaret @ekalda @lhutton1 @NicolaLancellotti ! |
ekalda
added a commit
to ekalda/tvm
that referenced
this pull request
Mar 24, 2022
This is a follow up to apache#10695. Change-Id: I7f2dc14826cefea81fe5ff69c6255cdb5dc7f5c0
ekalda
added a commit
to ekalda/tvm
that referenced
this pull request
Mar 25, 2022
This is a follow up to apache#10695. Change-Id: I7f2dc14826cefea81fe5ff69c6255cdb5dc7f5c0
manupak
pushed a commit
that referenced
this pull request
Mar 28, 2022
This is a follow up to #10695. Change-Id: I7f2dc14826cefea81fe5ff69c6255cdb5dc7f5c0
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
The cascader needs to be able to choose the block config for operations in order to accurately model their performance. The cascader must attach the chosen block config to the te.Schedule. This is done using a pragma. The chosen block config is also added to the TIR spec. If the cascader hasn't set a block config, it defaults to the existing block config selection behaviour. Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Matthew Barrett <[email protected]>
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…0764) This is a follow up to apache#10695. Change-Id: I7f2dc14826cefea81fe5ff69c6255cdb5dc7f5c0
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cascader needs to be able to choose the block config for operations in order to accurately model their performance.
The cascader must attach the chosen block config to the te.Schedule. This is done using a pragma. The chosen block config
is also added to the TIR spec. If the cascader hasn't set a block config, it defaults to the existing block config
selection behaviour.
Co-authored-by: Matthew Barrett [email protected]