Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TVMC] Support compiling and running with VM #10722

Merged
merged 6 commits into from
Mar 31, 2022
Merged

[TVMC] Support compiling and running with VM #10722

merged 6 commits into from
Mar 31, 2022

Conversation

margaretqian
Copy link
Contributor

No description provided.

@margaretqian margaretqian marked this pull request as draft March 23, 2022 06:08
jwfromm
jwfromm requested changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, Margaret! I've left some feedback on how some bits can be simplified but this overall looks excellent.

python/tvm/driver/tvmc/runner.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/runner.py Show resolved Hide resolved
python/tvm/driver/tvmc/model.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/compiler.py Show resolved Hide resolved
python/tvm/driver/tvmc/model.py Outdated Show resolved Hide resolved
@margaretqian margaretqian marked this pull request as ready for review March 30, 2022 01:56
jwfromm
jwfromm requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are excellent changes, I left a few very minor points of feedback. Once addressed I think we're ready to merge.

python/tvm/driver/tvmc/compiler.py Outdated Show resolved Hide resolved
python/tvm/driver/tvmc/model.py Outdated Show resolved Hide resolved
tests/python/driver/tvmc/test_model.py Show resolved Hide resolved
tests/python/driver/tvmc/test_runner.py Outdated Show resolved Hide resolved
jwfromm
jwfromm approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, it will make using the VM much easier. LGTM!

@jwfromm jwfromm merged commit 8775a80 into apache:main Mar 31, 2022
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
@margaretqian
[TVMC] Support compiling and running with VM (apache#10722)
7e5d84f 
* introduce vm compile path

* support vm in tvmc

* cleanup + lint

* add profiler + simplify vm case in tvmcpackage

* address comments + parametrize tests

Co-authored-by: Margaret Qian <[email protected]>
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
@margaretqian @mehrdadh
[TVMC] Support compiling and running with VM (apache#10722)
1006f9f 
* introduce vm compile path

* support vm in tvmc

* cleanup + lint

* add profiler + simplify vm case in tvmcpackage

* address comments + parametrize tests

Co-authored-by: Margaret Qian <[email protected]>
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
@masahi masahi mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwfromm jwfromm jwfromm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@margaretqian @jwfromm