-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE] fix docker install bug #10973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, and these changes look good overall to me! Just a small nitpick from me.
@@ -18,6 +18,8 @@ | |||
# Main Vitis AI docker env | |||
FROM xilinx/vitis-ai:1.4.916 | |||
|
|||
RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 6AF7F09730B3F0A4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment describing which key this is, why it needs to be added? Searching for the key finds this stackoverflow post, suggesting that it is related to kitware/cmake key, but it would be good to have that information in the file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, When I use this Dockerfile to build docker image, I met this error:
Err:7 https://apt.kitware.com/ubuntu bionic InRelease
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 6AF7F09730B3F0A4
So, I add this
RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 6AF7F09730B3F0A4
in dockrfile, and solved this error.
good point, we would need some better infra since the conditioning code is kind of a mess, but I would be in favor of rebuilding the demo images only when their specific Dockerfiles are edited (and also maybe continually with some cadence, maybe weekly) just because they seem to rarely get updates |
@driazati That would make sense to me, since the demo images aren't needed as frequently, and would primarily be updated alongside the demo itself. |
When I use docker/build.sh, I met some problems, and I solved it.
@Lunderberg - CI, Vulkan backend @YuchenJin @antinucleon