Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] fix docker install bug #10973

Closed
wants to merge 1 commit into from

Conversation

GoodMan-1
Copy link

@GoodMan-1 GoodMan-1 commented Apr 12, 2022

When I use docker/build.sh, I met some problems, and I solved it.
@Lunderberg - CI, Vulkan backend @YuchenJin @antinucleon

Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, and these changes look good overall to me! Just a small nitpick from me.

@@ -18,6 +18,8 @@
# Main Vitis AI docker env
FROM xilinx/vitis-ai:1.4.916

RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 6AF7F09730B3F0A4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment describing which key this is, why it needs to be added? Searching for the key finds this stackoverflow post, suggesting that it is related to kitware/cmake key, but it would be good to have that information in the file as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, When I use this Dockerfile to build docker image, I met this error:

Err:7 https://apt.kitware.com/ubuntu bionic InRelease
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 6AF7F09730B3F0A4

So, I add this
RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 6AF7F09730B3F0A4
in dockrfile, and solved this error.

@Lunderberg
Copy link
Contributor

@driazati The #10525 only rebuilds the docker images that are used as part of CI. Do we want to automatically build the demo docker images as well to avoid similar issues?

@driazati
Copy link
Member

@driazati The #10525 only rebuilds the docker images that are used as part of CI. Do we want to automatically build the demo docker images as well to avoid similar issues?

good point, we would need some better infra since the conditioning code is kind of a mess, but I would be in favor of rebuilding the demo images only when their specific Dockerfiles are edited (and also maybe continually with some cadence, maybe weekly) just because they seem to rarely get updates

@Lunderberg
Copy link
Contributor

@driazati That would make sense to me, since the demo images aren't needed as frequently, and would primarily be updated alongside the demo itself.

@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
@tqchen tqchen closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants