[microTVM] Bump versions in reference vm #11067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadh
reviewed
Apr 22, 2022
apps/microtvm/reference-vm/arduino/base-box/base_box_provision.sh
Outdated
Show resolved
Hide resolved
| @@ -23,7 +23,7 @@ set -o pipefail | |||
| export DEBIAN_FRONTEND=noninteractive | |||
| apt-get install -y ca-certificates | |||
|
|
|||
| ARDUINO_CLI_VERSION="0.18.3" | |||
| ARDUINO_CLI_VERSION="0.21.1" | |||
There was a problem hiding this comment.
can you consolidate arduino CLI installation into one script and reuse for both docker and RVM?
There was a problem hiding this comment.
We decided last summer that the scripts should be separate, as they aren't that similar. I'd be open to revisiting that topic, but it's OOS for this PR.
Made a change to lock versions for all the libraries. Thanks for taking a look! |
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
* Update spresense sdk version to make hack unnecessary * Bump arduino SDK version * Fix Arduino RPC server test * Fix versions for all board libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Spresense SDK and
arduino-clihad major bugs that required really nasty fixes inbase_box_provision.sh(see sonydevworld/spresense#200 and arduino/arduino-cli#1312, respectively).Both of these have been fixed in the latest versions, though. This PR updates the
arduino-cliversion to0.21.1, and sets the Spresense version to a generic latest version (as we do this for all the other board URLs). These allow us to remove the ugly hacks frombase_box_provision.sh.Note that this PR requires merging #11043 and #11095.
cc @gromero @mehrdadh