[microNPU] Adding a option to enable striping #11263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhutton1
approved these changes
May 11, 2022
There was a problem hiding this comment.
Thanks @manupa-arm LGTM! Just one small nit, but feel free to ignore
also cc @ekalda
| @@ -105,7 +105,8 @@ std::vector<bool> GetCascadableAxes(const Part& part) { | |||
| return cascadable_axes; | |||
| } | |||
|
|
|||
| std::vector<StripeConfig> GenerateOutputStripeConfigs(const Part& part, int stripe_factors) { | |||
| std::vector<StripeConfig> GenerateOutputStripeConfigs(const Part& part, int stripe_factors, | |||
| bool disable_striping = false) { | |||
There was a problem hiding this comment.
Nit: probably no need for a default here?
There was a problem hiding this comment.
Agreed and removed the default.
|
After having an offline discussion with @lhutton1 , we also decided to switch the polarity to enable the striping instead because we'd like to use block config selection done by the cascader without striping in a default run. |
manupak
changed the title
This commit adds a cascader option to enable striping explicitly. When doing so fixed a bug that is associated with block config selection, that will be triggered when striping is disabled. Co-authored-by: Elen Kalda <[email protected]>
|
Thanks @manupa-arm! |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
May 16, 2022
This commit adds a cascader option to enable striping explicitly. When doing so fixed a bug that is associated with block config selection, that will be triggered when striping is disabled. Co-authored-by: Elen Kalda <[email protected]>
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
This commit adds a cascader option to enable striping explicitly. When doing so fixed a bug that is associated with block config selection, that will be triggered when striping is disabled. Co-authored-by: Elen Kalda <[email protected]>
shingjan
pushed a commit
to shingjan/tvm
that referenced
this pull request
May 17, 2022
This commit adds a cascader option to enable striping explicitly. When doing so fixed a bug that is associated with block config selection, that will be triggered when striping is disabled. Co-authored-by: Elen Kalda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a cascader option to enable
striping explicitly.
When doing so fixed a bug that is associated
with block config selection, that will be
triggered when striping is disabled.
Co-authored-by: Elen Kalda [email protected]
cc @Mousius @lhutton1