-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Topi] [Hexagon] Conv2d slice op initial version #11489
Conversation
913fca3
to
ff6322d
Compare
cc @Lunderberg @cconvey for review. |
ff6322d
to
13868a6
Compare
8886c6b
to
ec94e08
Compare
@Lunderberg @cconvey Could you please take a look at this patch when you get a chance. I just rebased it to take advantage of Jyotsna's utils functions, so I think it's ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one question on the layout argument types.
b9dc9cb
to
bb2a8fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I restarted the job, not sure why CI wasn't started. |
bb2a8fa
to
48a2172
Compare
Thanks for this @mehrdadh. I just saw that there was a conflict in a file, so I just rebased my branch on top of main. |
48a2172
to
8a9d306
Compare
@Lunderberg @mehrdadh Are there any more comments and if not, could you please help get this merged. |
This patch adds the initial python implementation conv2d slice op for hexagon.
Slice ops are basically ops that make certain assumptions about the input and output dimensions and are expected to be called after the original op has been sliced according to those dimensions at the graph level.
cc @mehrdadh