Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topi] [Hexagon] Conv2d slice op initial version #11489

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

quic-sanirudh
Copy link
Contributor

@quic-sanirudh quic-sanirudh commented May 27, 2022

This patch adds the initial python implementation conv2d slice op for hexagon.

Slice ops are basically ops that make certain assumptions about the input and output dimensions and are expected to be called after the original op has been sliced according to those dimensions at the graph level.

cc @mehrdadh

@mehrdadh
Copy link
Member

cc @Lunderberg @cconvey for review.

@quic-sanirudh quic-sanirudh force-pushed the conv2d_slice branch 3 times, most recently from 8886c6b to ec94e08 Compare June 16, 2022 16:23
@quic-sanirudh
Copy link
Contributor Author

@Lunderberg @cconvey Could you please take a look at this patch when you get a chance. I just rebased it to take advantage of Jyotsna's utils functions, so I think it's ready for review now.

Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one question on the layout argument types.

python/tvm/topi/hexagon/slice_ops/conv2d.py Show resolved Hide resolved
@quic-sanirudh quic-sanirudh force-pushed the conv2d_slice branch 3 times, most recently from b9dc9cb to bb2a8fa Compare June 26, 2022 05:46
Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehrdadh
Copy link
Member

I restarted the job, not sure why CI wasn't started.

@quic-sanirudh
Copy link
Contributor Author

I restarted the job, not sure why CI wasn't started.

Thanks for this @mehrdadh. I just saw that there was a conflict in a file, so I just rebased my branch on top of main.

@quic-sanirudh
Copy link
Contributor Author

@Lunderberg @mehrdadh Are there any more comments and if not, could you please help get this merged.

@kparzysz-quic kparzysz-quic merged commit 95f5789 into apache:main Jul 6, 2022
@quic-sanirudh quic-sanirudh deleted the conv2d_slice branch July 6, 2022 14:54
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants