-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HEXAGON] Slice ops added - add, subtract, multiply #11529
Changes from 7 commits
11e1fc2
b8a82e1
037b7e2
009e536
8daeb73
7c08bd2
1462a3d
3da8f07
188fe44
f29844a
9b1d6c6
6bc4d4a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
""" Computes and Schedules for Hexagon slice ops. """ | ||
|
||
from .add_subtract_multiply import * |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
"""Compute and schedule for add, multiply, subtract slice op | ||
|
||
Please note the following assumptions made by the implementation: | ||
|
||
1) The inputs will be multiple of crouton layout except for the axis that needs broadcasting.""" | ||
|
||
from tvm import te | ||
from tvm import tir | ||
from tvm import topi | ||
from ..utils import get_layout_transform_fn | ||
|
||
|
||
def add_broadcast_compute(input_a, input_b): | ||
"""Call the add op from topi""" | ||
return topi.add(input_a, input_b) | ||
|
||
|
||
def subtract_broadcast_compute(input_a, input_b): | ||
"""Call the subtract op from topi""" | ||
return topi.subtract(input_a, input_b) | ||
|
||
|
||
def multiply_broadcast_compute(input_a, input_b): | ||
"""Call the multiply op from topi""" | ||
return topi.multiply(input_a, input_b) | ||
|
||
|
||
def tir_broadcast_schedule( | ||
out_m, | ||
input_a, | ||
input_b, | ||
output_layout: str, | ||
input_a_layout: str, | ||
input_b_layout: str, | ||
op_name: str, | ||
): | ||
"""Schedule for input and output layout nhwc-8h2w32c2w-2d considering broadcast""" | ||
func = te.create_prim_func([input_a, input_b, out_m]) | ||
|
||
s = tir.Schedule(func) | ||
|
||
block_dict = {"add": "T_add", "subtract": "T_subtract", "multiply": "T_multiply"} | ||
|
||
block = s.get_block(block_dict[op_name]) | ||
|
||
if input_a_layout == "nhwc-8h2w32c2w-2d": | ||
input_a_transformed_layout = get_layout_transform_fn(input_a_layout) | ||
s.transform_layout(block, buffer=("read", 0), index_map=input_a_transformed_layout) | ||
|
||
if input_b_layout == "nhwc-8h2w32c2w-2d": | ||
input_b_transformed_layout = get_layout_transform_fn(input_b_layout) | ||
s.transform_layout(block, buffer=("read", 1), index_map=input_b_transformed_layout) | ||
|
||
output_transformed_layout = get_layout_transform_fn(output_layout) | ||
s.transform_layout(block, buffer=("write", 0), index_map=output_transformed_layout) | ||
|
||
n, h, w, c = s.get_loops(block) | ||
|
||
h_o, h_i = s.split(h, [None, 8]) | ||
w_o, w_i = s.split(w, [None, 4]) | ||
c_o, c_i = s.split(c, [None, 32]) | ||
wio, wii = s.split(w_i, [None, 2]) | ||
|
||
s.reorder(n, h_o, w_o, c_o, h_i, wio, c_i, wii) | ||
|
||
fused = s.fuse(c_i, wii) | ||
s.vectorize(fused) | ||
|
||
return s |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
"""Common hexagon specific utilities""" | ||
from tvm import te | ||
|
||
|
||
def n11c_1024c_2d(n, h, w, c): | ||
"""Return index map for n11c_1024 2d layout""" | ||
return [n, h, w, c // 1024, te.AXIS_SEPARATOR, c % 1024] | ||
|
||
|
||
def n11c_1024c_1d(n, h, w, c): | ||
"""Return index map for n11c_1024 1d layout""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mehrdadh I am having the same lint error about argument variable "w" here as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since these are utility functions, it would be great if you can use better naming. |
||
return [n, h, w, c // 1024, c % 1024] | ||
|
||
|
||
def nhwc_8h2w32c2w_2d(n, h, w, c): | ||
"""Return index map for nhwc_8h2w32c2w 2d layout""" | ||
return [n, h // 8, w // 4, c // 32, te.AXIS_SEPARATOR, h % 8, (w % 4) // 2, c % 32, w % 2] | ||
|
||
|
||
def nhwc_8h2w32c2w_1d(n, h, w, c): | ||
"""Return index map for nhwc_8h2w32c2w 1d layout""" | ||
return [n, h // 8, w // 4, c // 32, h % 8, (w % 4) // 2, c % 32, w % 2] | ||
|
||
|
||
def get_layout_transform_fn(layout): | ||
"""Return index map function as per the layout string""" | ||
if layout == "nhwc-8h2w32c2w-2d": | ||
return nhwc_8h2w32c2w_2d | ||
if layout == "nhwc-8h2w32c2w-1d": | ||
return nhwc_8h2w32c2w_1d | ||
if layout == "n11c-1024c-2d": | ||
return n11c_1024c_2d | ||
if layout == "n11c-1024c-1d": | ||
return n11c_1024c_1d | ||
raise RuntimeError(f"Unexpected layout '{layout}'") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehrdadh lint error is complaining about the variable name "w". It's not complaining about "n" or "h" or "c". Is it a reasonable error? Is there a way to stick to these simple(single letter) variable names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. we might need to add pylint disable in this file.