Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hexagon] Add random string to workspace name #11593

Merged
merged 1 commit into from
Jun 8, 2022
Merged

[Hexagon] Add random string to workspace name #11593

merged 1 commit into from
Jun 8, 2022

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Jun 6, 2022

This is to avoid workspace collision in case the test was skipped/xfailed quickly.

@mehrdadh mehrdadh requested a review from Lunderberg June 6, 2022 17:32
Lunderberg
Lunderberg approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for spinning this out from #11547.

@Lunderberg Lunderberg mentioned this pull request Jun 6, 2022
Merged
@mehrdadh
Copy link
Member Author

mehrdadh commented Jun 7, 2022

let's not merge this until Hexagon CI is fixed.

@mehrdadh mehrdadh merged commit 97e681d into apache:main Jun 8, 2022
@mehrdadh mehrdadh deleted the hexagon/launcher_random_directory_name branch June 8, 2022 20:24
Kathryn-cat pushed a commit to Kathryn-cat/tvm that referenced this pull request Jun 10, 2022
@mehrdadh @Kathryn-cat
[Hexagon] Add random string to workspace name (apache#11593)
786df2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunderberg Lunderberg Lunderberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehrdadh @Lunderberg