Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] [PyTorch] Add aten::tril and aten::triu #11890

Merged
merged 3 commits into from
Jul 1, 2022
Merged

[Relay] [PyTorch] Add aten::tril and aten::triu #11890

merged 3 commits into from
Jul 1, 2022

Conversation

shingjan
Copy link

@shingjan shingjan commented Jun 24, 2022 •
edited by driazati
Loading

This pr intends to add aten::tril and aten:triu ops in the pytorch frontend. Fixes #11967

cc: @masahi @junrushao1994 @zxybazh @vinx13

@shingjan shingjan marked this pull request as ready for review July 1, 2022 04:49
@shingjan
Copy link
Author

shingjan commented Jul 1, 2022

@masahi This PR should be ready for review.

@altanh @driazati This PR should also fix the flaky tests around empty and empty_like as we only compare shape of the ouputs now for those two.

@shingjan shingjan mentioned this pull request Jul 1, 2022
Closed
@shingjan shingjan changed the title [Relay] [PyTorch] Add trilu, tril and triu [Relay] [PyTorch] Add aten::tril and aten::triu Jul 1, 2022
@masahi masahi merged commit 1787cca into apache:main Jul 1, 2022
@shingjan shingjan deleted the torch_trilu branch July 5, 2022 22:58
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
@blackkker
[Relay] [PyTorch] Add aten::tril and aten::triu (apache#11890)
d2f27af 
* add trilu

* update triu and tril; fix empty

* fix lint
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
@masahi
[Relay] [PyTorch] Add aten::tril and aten::triu (apache#11890)
417cc76 
* add trilu

* update triu and tril; fix empty

* fix lint
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
[Relay] [PyTorch] Add aten::tril and aten::triu (apache#11890)
437f0b0 
* add trilu

* update triu and tril; fix empty

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky Test] tests/python/frontend/pytorch/test_forward.py::test_empty_like
2 participants
@shingjan @masahi