-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay] CaptureIndexInSpans debugging pass #11926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbs-octoml
force-pushed
the
mbs-collage-index-in-spans
branch
from
June 28, 2022 00:16
0009ecc
to
408d419
Compare
masahi
reviewed
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming CaptureIndexInSpans()
to CapturePostDFSOrderInSpans()
? Since it's not clear what "Index" means.
Assuming they mean the same thing.
This pass will update (most) expression nodes to capture their post-dfs indexes. That makes it easy to connect pretty-printed fragments back to the overall model, and is very handy for Collage which uses post-dfs indexes extensively.
mbs-octoml
force-pushed
the
mbs-collage-index-in-spans
branch
from
June 28, 2022 17:30
408d419
to
1b3eb16
Compare
Ready for submit once ci green, thank you. |
@tvm-bot rerun |
masahi
approved these changes
Jun 28, 2022
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* [Relay] CaptureIndexInSpans debugging pass This pass will update (most) expression nodes to capture their post-dfs indexes. That makes it easy to connect pretty-printed fragments back to the overall model, and is very handy for Collage which uses post-dfs indexes extensively. * - rename - add header decl
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* [Relay] CaptureIndexInSpans debugging pass This pass will update (most) expression nodes to capture their post-dfs indexes. That makes it easy to connect pretty-printed fragments back to the overall model, and is very handy for Collage which uses post-dfs indexes extensively. * - rename - add header decl
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [Relay] CaptureIndexInSpans debugging pass This pass will update (most) expression nodes to capture their post-dfs indexes. That makes it easy to connect pretty-printed fragments back to the overall model, and is very handy for Collage which uses post-dfs indexes extensively. * - rename - add header decl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass will update (most) expression nodes to capture their post-dfs
indexes. That makes it easy to connect pretty-printed fragments back to
the overall model, and is very handy for Collage which uses post-dfs indexes
extensively.