[Collage] PartitionRule (though without CombinePartitionRule) #11993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbs-octoml
force-pushed
the
mbs-collage-partition-rule
branch
from
679be53 to
3b746b2
Compare
See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981.
mbs-octoml
force-pushed
the
mbs-collage-partition-rule
branch
from
3b746b2 to
5903ed1
Compare
|
This is now based on main and ready for review, thanks. |
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops
junrushao
pushed a commit
to yelite/tvm
that referenced
this pull request
Jul 27, 2022
…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…#11993) * [Collage] PartitionRule (though without CombinePartitionRule) See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. (Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.) Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion. Based on apache#11981. * - Backport improvements to partiton_rule_test.cc * - Oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md.
(Special thanks to Matthew Barrett for authoring partition_rule_test.cc and suggesting a PR partitioning strategy.)
Collage uses a small 'combinator library' of PartitionRule to decribe how candidate partitions can be extracted from a model for measurement and comparison. This introduces most of that machinery, however we defer the all important 'CombinerPartitionRule' for the next PR. Thus the rules at this stage can only express the sorts of DFPattern-based rules we find in most BYOC integrations, and cannot describe rules more traditionally associated with operator fusion.