[TVMScript] StmtDoc Printing #12112
Merged
[TVMScript] StmtDoc Printing #12112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Closed
yelite
force-pushed
the
tunip-stmt-doc-printing
branch
3 times, most recently
from
e7de83b to
871b3e3
Compare
yelite
force-pushed
the
tunip-stmt-doc-printing
branch
2 times, most recently
from
f52ac4d to
763ff53
Compare
junrushao
pushed a commit
to yelite/tvm
that referenced
this pull request
Jul 27, 2022
This PR addes: - Awareness of expression (operator) precedence during Python code printing (`(* 1 (+ 2 3))` prints as `1 * (2 + 3)`) Tracking issue: apache#11912 This PR is in draft state because it's branched off an open PR apache#12112.
yelite
force-pushed
the
tunip-stmt-doc-printing
branch
from
763ff53 to
d0d9006
Compare
junrushao
reviewed
Jul 28, 2022
| doc.comment = "1\n2" | ||
| with pytest.raises(ValueError) as e: | ||
| to_python_script(doc) | ||
| assert "cannot have newline" in str(e.value) |
There was a problem hiding this comment.
Let's append some epilogues to this file so that it could be runnable with python /path/to/file
if __name__ == "__main__":
tvm.testing.main()
junrushao
reviewed
Jul 28, 2022
Comment on lines
+447
to
+448
| output_ << " -> "; | ||
| PrintDoc(doc->return_type); |
There was a problem hiding this comment.
Shall we consider the case where return_type is not given?
junrushao
pushed a commit
to yelite/tvm
that referenced
this pull request
Aug 1, 2022
This PR: - Handle expression (operator) precedence during Python code printing (`(* 1 (+ 2 3))` prints as `1 * (2 + 3)`) - Addresses remaining feedback from previous PR apache#12112 - Reformats Python import with isort Tracking issue: apache#11912
junrushao
pushed a commit
that referenced
this pull request
Aug 1, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR addes: - StmtDoc Printing in PythonDocPrinter Tracking issue: apache#11912
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR: - Handle expression (operator) precedence during Python code printing (`(* 1 (+ 2 3))` prints as `1 * (2 + 3)`) - Addresses remaining feedback from previous PR apache#12112 - Reformats Python import with isort Tracking issue: apache#11912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addes:
Tracking issue: #11912
cc @junrushao1994 @gbonik