[microTVM][Zephyr][projectAPI] Minimize project build commands #12209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadh
force-pushed
the
micro/make_build_simple
branch
from
0bfa420 to
f974ff9
Compare
gromero
requested changes
Jul 28, 2022
gromero
requested changes
Jul 28, 2022
|
|
||
| if not zephyr_board: | ||
| raise RuntimeError( | ||
| f"Zephyr Board is not found in the {API_SERVER_DIR / CMAKELIST_FILENAME}" |
There was a problem hiding this comment.
Could this message be changed to "No Zephyr board defined in the {API_SERVER_DIR / CMAKELIST_FILENAME}" ? Or "set in the ..." ?
|
Otherwise, LGTM 👍 |
mehrdadh
commented
Jul 28, 2022
|
|
||
| if not zephyr_board: | ||
| raise RuntimeError( | ||
| f"Zephyr Board is not found in the {API_SERVER_DIR / CMAKELIST_FILENAME}" |
gromero
requested changes
Jul 28, 2022
tests/micro/common/test_tvmc.py
Outdated
| [pathlib.Path("./tvmc_relative_path_test"), pathlib.Path(tempfile.mkdtemp())], | ||
| [ | ||
| pathlib.Path("./tvmc_relative_path_test"), | ||
| # pathlib.Path(tempfile.mkdtemp()) |
There was a problem hiding this comment.
Is that line really to be a comment?
There was a problem hiding this comment.
thanks for catching, fixed it
mehrdadh
force-pushed
the
micro/make_build_simple
branch
from
0d85909 to
30515eb
Compare
gromero
approved these changes
Jul 28, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…e#12209) * move cmake args to generate project * remove zephyr board from flash and run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Zephyr template project to populate all configs in Cmake file and minimize the command to build the project.
Before this PR we had to do this:
After this PR:
This PR also removes some of the redundancies in passing project options like zephyr_board.
cc @alanmacd @gromero @guberti