[ci] Add linter for PR title and body #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
force-pushed
the
pr_linter
branch
7 times, most recently
from
1437ca6 to
68cfdc1
Compare
driazati
force-pushed
the
pr_linter
branch
2 times, most recently
from
2a31748 to
da98213
Compare
7 tasks
This got out of date after merging apache#12178 Co-authored-by: driazati <[email protected]>
|
No additional skipped tests found in this branch for commit 24b4440. |
areusch
approved these changes
Aug 31, 2022
|
hey @driazati thanks for adding this linter. I found it not throwing meaningful CI failure message when PR body is missing (empty). Here are the CI error message: Shall we improve it? |
|
thanks for flagging that! #12680 should fix it |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [skip ci][ci] Fix Jenkinsfile (apache#12387) This got out of date after merging apache#12178 Co-authored-by: driazati <[email protected]> * Address comments Co-authored-by: driazati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lint step that checks the PR title and body with some of the basic checks from apache/tvm-rfcs#88. This makes it so we can enforce the decided rules without having to rely on automated fix-ups, though for certain things those would be ideal in the future. The rules implemented here are not complete as the RFC is not fully merged but this is just supposed to be a starting point with some of the basic rules, namely that a title and body should be present. A follow up PR will enforce that there are no @ tags once #12637 is resolved.
cc @Mousius @areusch @gigiblender @gromero @leandron