[AOT] Refactor AOTExecutorCodegenModule using new AOT passes #12549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mbaret
force-pushed
the
aot-refactor
branch
2 times, most recently
from
cb31974 to
9d68820
Compare
areusch
added
needs-triage
mbaret
force-pushed
the
aot-refactor
branch
2 times, most recently
from
fd4aeb3 to
e6d45bb
Compare
mbaret
force-pushed
the
aot-refactor
branch
3 times, most recently
from
d47bb10 to
3405e4f
Compare
Device contexts created handles with no corresponding buffer which would confuse CreateFunctionMetadata causing a segfault. The logic has been changed to check that a buffer exists and a test updated to include this case.
This commit refactors the AOTExecutorCodegenModule to make use of the newly introduced AOT passes AOTLowerMain, CreateFunctionMetadata and CreateExecutor metadata. Some modifications are additionally made to the 'Codegen' interface to make important code generation options explicit.
mbaret
changed the title
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #12548
This commit refactors the AOTExecutorCodegenModule to make use of the newly introduced AOT passes AOTLowerMain, CreateFunctionMetadata and CreateExecutor metadata. Some modifications are additionally made to the 'Codegen' interface to make important code generation options explicit.