Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHOSN] Use pytest parameterization for integration tests #12688

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Sep 2, 2022

Using PyTest parameterization helps identify the particular parameter combinations that are failing for a given test. Additionally, it can be useful when parallelizing the tests. This commit makes sure that "trials" have been replaced by parameterization as well as completing a general cleanup.

cc @leandron @NicolaLancellotti

Using pytest parameterization helps identify the particular parameter
combinations that are failing for a given test. Additionally, it can be
useful when parallelizing the tests. This commit makes sure that
"trials" have been replaced by parameterization as well as completing a
general cleanup.

Change-Id: Iaabefaa8a2f316c9f403ac793fbd42b98edf9033
@github-actions github-actions bot requested a review from leandron September 2, 2022 14:31
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The new version is much more elegant. Great work @lhutton1!

@lhutton1 lhutton1 merged commit 5dcf622 into apache:main Sep 5, 2022
@lhutton1 lhutton1 deleted the use-pytest-parameterization branch September 5, 2022 08:27
@lhutton1
Copy link
Contributor Author

lhutton1 commented Sep 5, 2022

Thanks @leandron!

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
)

Using pytest parameterization helps identify the particular parameter combinations that are failing for a given test. Additionally, it can be useful when parallelizing the tests. This commit makes sure that "trials" have been replaced by parameterization as well as completing a general cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants