-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] 2-Stage Pipeline; Lower Async TIR primitives to Hexagon User DMA #12785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adstraw
commented
Sep 14, 2022
masahi
reviewed
Sep 15, 2022
@tvm-bot rerun |
masahi
approved these changes
Sep 20, 2022
@tvm-bot rerun |
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/3091706323
|
Thanks @adstraw, @JosephTheOctonaut and @masahi for the PR and the reviews, the PR has been merged! |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…r DMA (apache#12785) * [Hexagon] 2-Stage Pipeline; Lower Async TIR primitives to HexagonUserDMA * save queue ID in `copy`, inspect in `wait` transform; add comments * improve testing; parameters for shape, scope, dtype * add log statements and adjust comments to clarify pass behavior * generalize use_async_copy for pass enable * use DLOG instead of LOG * trigger ci * trigger ci again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a 2-stage pipeline (DMA, compute) by lowering Async TIR primitives (see RFC) with memory copy semantics to builtin functions for DMA
Copy
andWait
. These builtins can then be lowered through the device API, with example lowering on Hexagon to theHexagonUserDMA
class. The example test case contained in this PR creates a 2 stage pipeline which lowers to the following TIR which is built and run on Hexagon.