Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetaSchedule] PyDatabase Complete Function Reload Support #12838

Merged
merged 8 commits into from
Sep 20, 2022
Merged

[MetaSchedule] PyDatabase Complete Function Reload Support #12838

merged 8 commits into from
Sep 20, 2022

Conversation

zxybazh
Copy link
Member

@zxybazh zxybazh commented Sep 19, 2022

This PR follows up #12520 and completes the functions in PyDatabase class and make sure we can override the query_tuning_records, query_schedule and query_ir_module function. Meanwhile, user can also use query function or use PyDatabase as a context.

@zxybazh zxybazh marked this pull request as ready for review September 19, 2022 17:46
@zxybazh
Copy link
Member Author

zxybazh commented Sep 19, 2022

Tests added for both default & overrided function case. Ready for review!

junrushao
junrushao approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

@zxybazh zxybazh merged commit a75dcab into apache:main Sep 20, 2022
@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Oct 4, 2022
Closed
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@zxybazh @xinetzone
[MetaSchedule] PyDatabase Complete Function Reload Support (apache#12838
a26904d 
)

* Save for PR.

* Fix database default query function call.

* Add test.

* Fix lint.

* Remove unused import.

* Differentiate override class.

* Reuse outer class functions.

* Fix lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxybazh @junrushao