Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] disable cache_write schedule type from sw pipeline test #13004

Merged

Conversation

adstraw
Copy link
Contributor

@adstraw adstraw commented Oct 6, 2022

Disabling the "cache_write" schedule from this test as it is failing on device. The root cause of the failure will be addressed with additional buffer dependency analysis in the InjectSoftwarePipeline pass to come in a subsequent PR.

@masahi
Copy link
Member

masahi commented Oct 6, 2022

I'm seeing "1 workflow awaiting approval (First-time contributors need a maintainer to approve running workflows)" in this PR, while @adstraw is obviously not a first time contributor. Why is that? cc @driazati

UPDATE: #13005 has the same issue.

@driazati
Copy link
Member

driazati commented Oct 7, 2022

I'm seeing "1 workflow awaiting approval (First-time contributors need a maintainer to approve running workflows)" in this PR, while @adstraw is obviously not a first time contributor. Why is that? cc @driazati

UPDATE: #13005 has the same issue.

Not sure why (seems like a bug from GitHub?), since even on the hover on @adstraw's profile it says there are recent contributions. ASF Infra might have changed something in the repo settings but it seems unlikely that they would do that without telling us / it would even cause this kind of behavior. I've approved both PRs, if you notice anything else like this please tag me on it

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmoreau89 tmoreau89 merged commit 7804a98 into apache:main Oct 7, 2022
@adstraw adstraw deleted the straw-hexagon-disable-cache-write-only-sched branch October 10, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants