Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Lint for trailing newlines and spaces #13058

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

driazati
Copy link
Member

@driazati driazati commented Oct 12, 2022

This adds a short lint to ensure that all files have a single trailing newline and no trailing whitespaces. This PR is in two commits, one to add the check and another to fix currently offending files in the repo. See ba2c2e2 for just the significant changes. Auto-corrections applied with

pre-commit run --all-files

@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 12, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@driazati driazati changed the title Lint fixups to pass CI [ci] Check for trailing newlines and spaces Oct 12, 2022
@driazati
Copy link
Member Author

@tvm-bot rerun

@driazati driazati changed the title [ci] Check for trailing newlines and spaces [ci] Lint for trailing newlines and spaces Oct 12, 2022
@driazati driazati marked this pull request as ready for review October 13, 2022 00:01
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. It's very good checking. Sorry, I'm not a fully understand some of the changes and I asked questions about them.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
ci/scripts/git_skip_ci_globs.py Show resolved Hide resolved
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

tests/lint/trailing_newlines.py Show resolved Hide resolved
This adds a short lint to ensure that all files have a single trailing
newline and no trailing whitespaces.
@driazati driazati merged commit a4840e7 into apache:main Oct 19, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This adds a short lint to ensure that all files have a single trailing newline and no trailing whitespaces. This PR is in two commits, one to add the check and another to fix currently offending files in the repo. See apache@ba2c2e2 for just the significant changes. Auto-corrections applied with

```
pre-commit run --all-files
```
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This adds a short lint to ensure that all files have a single trailing newline and no trailing whitespaces. This PR is in two commits, one to add the check and another to fix currently offending files in the repo. See apache@ba2c2e2 for just the significant changes. Auto-corrections applied with

```
pre-commit run --all-files
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants