Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] Add CreateFunctionMetadata analysis pass #13095

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

mbaret
Copy link
Contributor

@mbaret mbaret commented Oct 17, 2022

Tracking issue: #12548

AOT requires FunctionInfo to be defined for all the functions in the module. This stores information on how much memory the functions use. This commit adds a separate analysis pass to create all the FunctionInfos + some tests for the new pass.

AOT requires FunctionInfo to be defined for all the functions
in the module. This stores information on how much memory the
functions use. This commit adds a separate analysis pass to
create all the FunctionInfos + some tests for the new pass.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Oct 17, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@mbaret
Copy link
Contributor Author

mbaret commented Oct 17, 2022

cc also @ekalda
(apologies for late follow-up, have been away for a while)

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mbaret , left a couple small comments.

src/relay/backend/aot/create_function_metadata.cc Outdated Show resolved Hide resolved
src/relay/backend/aot/create_function_metadata.cc Outdated Show resolved Hide resolved
@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbaret, looks great! LGTM modulo @areusch's comments

@mbaret
Copy link
Contributor Author

mbaret commented Oct 24, 2022

@lhutton1 @areusch anything else needed here or are we good to merge?

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more from me, LGTM!

@mbaret
Copy link
Contributor Author

mbaret commented Oct 24, 2022

@lhutton1 Andrew's on holiday for a couple of weeks, so would it be OK to merge without his approval? Think I addressed his comments :)

@lhutton1 lhutton1 merged commit c302b3d into apache:main Oct 24, 2022
@lhutton1
Copy link
Contributor

Thanks @mbaret @areusch!

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
AOT requires FunctionInfo to be defined for all the functions
in the module. This stores information on how much memory the
functions use. This commit adds a separate analysis pass to
create all the FunctionInfos + some tests for the new pass.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
AOT requires FunctionInfo to be defined for all the functions
in the module. This stores information on how much memory the
functions use. This commit adds a separate analysis pass to
create all the FunctionInfos + some tests for the new pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants