Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Add pylint on tests #13233

Merged
merged 3 commits into from
Nov 2, 2022
Merged

[Hexagon] Add pylint on tests #13233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a7afeb
[Hexagon] Tests pylint
mehrdadh Aug 29, 2022
fe11aec
fix error
mehrdadh Oct 28, 2022
f24020e
Fix buffer name
mehrdadh Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions tests/lint/pylint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,9 @@ python3 -m pylint tests/python/ci --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/integration/ --rcfile="$(dirname "$0")"/pylintrc

# tests/python/contrib/test_hexagon tests
python3 -m pylint tests/python/contrib/test_hexagon/benchmark_util.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/conftest.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/conv2d/test_conv2d_blocked.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/conv2d/test_conv2d_conv2d.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/infrastructure.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_2d_physical_buffers.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_autotvm.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_cache_read_write.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_launcher.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_maxpool2d_blocked.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_models.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_run_unit_tests.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_thread_pool.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/test_usmp.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/*.py --rcfile="$(dirname "$0")"/pylintrc
python3 -m pylint tests/python/contrib/test_hexagon/conv2d/*.py --rcfile="$(dirname "$0")"/pylintrc


# tests/python/frontend tests
python3 -m pylint tests/python/frontend/caffe/test_forward.py --rcfile="$(dirname "$0")"/pylintrc
Expand Down
36 changes: 18 additions & 18 deletions tests/python/contrib/test_hexagon/pytest_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
# specific language governing permissions and limitations
# under the License.

import pytest
import numpy as np
from typing import *
""" Hexagon pytest utility functions """

from typing import List, Optional, Union
import collections
import tvm.testing
import numpy as np


def get_test_id(*test_params, test_param_descs: List[Optional[str]] = None) -> str:
Expand Down Expand Up @@ -47,35 +47,35 @@ def get_test_id(*test_params, test_param_descs: List[Optional[str]] = None) -> s
assert len(test_param_descs) == len(test_params)

def get_single_param_chunk(param_val, param_desc: Optional[str]):
if type(param_val) == list:
if isinstance(param_val, list):
# Like str(list), but avoid the whitespace padding.
val_str = "[" + ",".join(str(x) for x in param_val) + "]"
need_prefix_separator = False

elif type(param_val) == bool:
elif isinstance(param_val, bool):
if param_val:
val_str = "T"
else:
val_str = "F"
need_prefix_separator = True

elif type(param_val) == TensorContentConstant:
elif isinstance(param_val, TensorContentConstant):
val_str = f"const[{param_val.elem_value}]"
need_prefix_separator = True

elif type(param_val) == TensorContentDtypeMin:
elif isinstance(param_val, TensorContentDtypeMin):
val_str = "min"
need_prefix_separator = True

elif type(param_val) == TensorContentDtypeMax:
elif isinstance(param_val, TensorContentDtypeMax):
val_str = "max"
need_prefix_separator = True

elif type(param_val) == TensorContentRandom:
elif isinstance(param_val, TensorContentRandom):
val_str = "random"
need_prefix_separator = True

elif type(param_val) == TensorContentSequentialCOrder:
elif isinstance(param_val, TensorContentSequentialCOrder):
val_str = f"seqC[start:{param_val.start_value},inc:{param_val.increment}]"
need_prefix_separator = True

Expand Down Expand Up @@ -148,26 +148,26 @@ def create_populated_numpy_ndarray(
"""
itp = input_tensor_populator # just for brevity

if type(itp) == TensorContentConstant:
if isinstance(itp, TensorContentConstant):
return np.full(tuple(input_shape), itp.elem_value, dtype=dtype)

elif type(itp) == TensorContentDtypeMin:
elif isinstance(itp, TensorContentDtypeMin):
info = get_numpy_dtype_info(dtype)
return np.full(tuple(input_shape), info.min, dtype=dtype)

elif type(itp) == TensorContentDtypeMax:
elif isinstance(itp, TensorContentDtypeMax):
info = get_numpy_dtype_info(dtype)
return np.full(tuple(input_shape), info.max, dtype=dtype)

elif type(itp) == TensorContentRandom:
elif isinstance(itp, TensorContentRandom):
return np.random.random(input_shape).astype(dtype)

elif type(itp) == TensorContentSequentialCOrder:
elif isinstance(itp, TensorContentSequentialCOrder):
a = np.empty(tuple(input_shape), dtype)

with np.nditer(a, op_flags=["writeonly"], order="C") as it:
with np.nditer(a, op_flags=["writeonly"], order="C") as iterator:
next_elem_val = itp.start_value
for elem in it:
for elem in iterator:
elem[...] = next_elem_val
next_elem_val += itp.increment
return a
Expand Down
Loading