[microNPU] Fixed MergeConstants pass on striped networks #13281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
sergio-grovety
force-pushed
the
ethosu-mergeconstant-striped-networks
branch
from
d651284 to
fd1f6d7
Compare
lhutton1
reviewed
Nov 7, 2022
There was a problem hiding this comment.
Thanks @sergey-grovety looks great! LGTM providing CI passes. Also cc @ekalda, @NicolaLancellotti who might have more context on this
|
Thanks @sergey-grovety @NicolaLancellotti! |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
This PR fixes the bug in MergeConstants pass on striped networks on Ethos-U NPU. The issue was caused by _DivideConstants_ pass which is introducing new mod parameters and changing their order. So ethosu_write parameter in some cases is moved from the end of the list to the middle. E.g. from: `[ethos-u_0_i0, p1, p2, p3, p4, p5, p6, ethosu_write]` To: `[ethos-u_0_i0, p1, p2, ethosu_write, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder]` Updated version of the _GetArgsToMergeWithoutArgsNotInConstDict_ and _MakeNewConstDict_ methods in passes.cc can now correctly modify const_dict according to the new parameter list.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR fixes the bug in MergeConstants pass on striped networks on Ethos-U NPU. The issue was caused by _DivideConstants_ pass which is introducing new mod parameters and changing their order. So ethosu_write parameter in some cases is moved from the end of the list to the middle. E.g. from: `[ethos-u_0_i0, p1, p2, p3, p4, p5, p6, ethosu_write]` To: `[ethos-u_0_i0, p1, p2, ethosu_write, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder]` Updated version of the _GetArgsToMergeWithoutArgsNotInConstDict_ and _MakeNewConstDict_ methods in passes.cc can now correctly modify const_dict according to the new parameter list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug in MergeConstants pass on striped networks on Ethos-U NPU.
The issue was caused by DivideConstants pass which is introducing new mod parameters and changing their order. So ethosu_write parameter in some cases is moved from the end of the list to the middle.
E.g. from:
[ethos-u_0_i0, p1, p2, p3, p4, p5, p6, ethosu_write]To:
[ethos-u_0_i0, p1, p2, ethosu_write, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder, placeholder]Updated version of the GetArgsToMergeWithoutArgsNotInConstDict and MakeNewConstDict methods in passes.cc can now correctly modify const_dict according to the new parameter list.
cc @leandron