Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Fix TIR vrmpy tensorization #13404

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

masahi
Copy link
Member

@masahi masahi commented Nov 16, 2022

Hexagon tests using vrmpy tensorization were broken by the change in tir/tensor_intrin/hexagon.py from #12496. The change is a correct one from the TIR perspective, but it breaks tensorize pattern matching. Actually T.init() block is not necessary in a tensorize description, so just removing it fixes the breakage.

@mehrdadh

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 16, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@masahi masahi changed the title [Hexagon] Fix vrmpy tensorization [Hexagon] Fix TIR vrmpy tensorization Nov 16, 2022
@mehrdadh mehrdadh merged commit b4d4b82 into apache:main Nov 16, 2022
@junrushao
Copy link
Member

Oh thanks for the update! In TIR, formally speaking, T.init() should only appear strictly under T.block(), so we got it removed to conform to the spec

xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants