-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] [ONNX] Support sequence_lens of GRU #13587
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Could you please review this PR @masahi? Thanks! |
@tvm-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are two simple corrections: update GRU_cell description and test params for correct check of new feature
# Testing with initial state | ||
if rnn_type == "GRU": | ||
verify_rnn( | ||
seq_length=2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increase seq_length (to 4-5 or more) and batch_size (to 4-8) for correct test of sequence with different lengths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -737,6 +737,7 @@ def gru_cell( | |||
n_act=_op.tanh, | |||
backwards=False, | |||
linear_before_reset=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add description of arguments linear_before_reset
and sequence_lens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
140cc4b
to
29241c8
Compare
Support convert sequence_lens input of GRU.
29241c8
to
67e7dc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Hello @masahi, could you recheck and merge this RP?
[Frontend] [ONNX] Support sequence_lens of GRU. Support convert sequence_lens input of GRU.
[Frontend] [ONNX] Support sequence_lens of GRU. Support convert sequence_lens input of GRU.
Support convert sequence_lens input of GRU.