Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] [ONNX] Support sequence_lens of GRU #13587

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

jacquesguan
Copy link
Contributor

Support convert sequence_lens input of GRU.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 9, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@jacquesguan
Copy link
Contributor Author

Could you please review this PR @masahi? Thanks!

@masahi masahi changed the title [Frontend] [ONNX] Support sequence_lens of GRU. [Frontend] [ONNX] Support sequence_lens of GRU Dec 12, 2022
@masahi
Copy link
Member

masahi commented Dec 12, 2022

@tvm-bot rerun

@masahi
Copy link
Member

masahi commented Dec 13, 2022

cc @vvchernov @AndrewZhaoLuo

Copy link
Contributor

@vvchernov vvchernov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are two simple corrections: update GRU_cell description and test params for correct check of new feature

# Testing with initial state
if rnn_type == "GRU":
verify_rnn(
seq_length=2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase seq_length (to 4-5 or more) and batch_size (to 4-8) for correct test of sequence with different lengths

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -737,6 +737,7 @@ def gru_cell(
n_act=_op.tanh,
backwards=False,
linear_before_reset=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description of arguments linear_before_reset and sequence_lens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Support convert sequence_lens input of GRU.
Copy link
Contributor

@vvchernov vvchernov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hello @masahi, could you recheck and merge this RP?

@masahi masahi merged commit 06be0b3 into apache:main Dec 15, 2022
@jacquesguan jacquesguan deleted the gru_onnx branch December 15, 2022 06:26
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
[Frontend] [ONNX] Support sequence_lens of GRU.

Support convert sequence_lens input of GRU.
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
[Frontend] [ONNX] Support sequence_lens of GRU.

Support convert sequence_lens input of GRU.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants