[microTVM] Build standalone_crt with cmake instead of makefile

[alanmacd]

Build standalone_crt with cmake instead of makefile to allow for better portability of microTVM code to other build environments.

fixes #13533

[tvm-bot]

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

• cc @gromero, @leandron, @mehrdadh, @mkatanbaf _{See #10317 for details}

_{Generated by tvm-bot}

[leandron]

Thanks @alanmacd, I think this makes the build process for standalone_crt much cleaner.

One comment I have is related to the python packaging mechanism. As part of packaging TVM will look for the standalone_crt directory (I think it is the copied one, as referred in #13533) to add the static files to the package. Can you double check whether that behaviour is also kept while you propose these changes?

The static files are needed so that users can integrate embedded projects only with the TVM installed from the package, rather than requiring the package+cloning apache/tvm repo.

tvm/python/setup.py

Lines 59 to 64 in b7015bb

	# Add standalone_crt, if present
	for name in lib_path:
	candidate_path = os.path.join(os.path.dirname(name), "standalone_crt")
	if os.path.isdir(candidate_path):
	libs.append(candidate_path)
	break

[alanmacd]

The static files are needed so that users can integrate embedded projects only with the TVM installed from the package, rather than requiring the package+cloning apache/tvm repo.

tvm/python/setup.py

Lines 59 to 64 in b7015bb

	# Add standalone_crt, if present
	for name in lib_path:
	candidate_path = os.path.join(os.path.dirname(name), "standalone_crt")
	if os.path.isdir(candidate_path):
	libs.append(candidate_path)
	break

Thanks @leandron I will verify that files are placed in the same locations as previous done with the makefile version (I may have stashed the library files in slightly different locations)

Is there a specific way you typically invoke setup.py to exercise this feature or an example command that I should use to test?

[leandron]

Is there a specific way you typically invoke setup.py to exercise this feature or an example command that I should use to test?

Build TVM with USE_MICRO ON, then cd python; python setup.py bdist_wheel.

Also, if that helps with context, the real use case would be following tlcpack steps https://github.com/tlc-pack/tlcpack

[alanmacd]

python setup.py bdist_wheel

@leandron ok, it looks like it's only copying the standalone_crt directory into the wheel, I've updated my PR to not put the library binaries in the standalone_crt directory (matching the current TVM main), all the other files should be the same as I didn't change the standalone_crt file copy code.

[leandron]

@leandron ok, it looks like it's only copying the standalone_crt directory into the wheel, I've updated my PR to not put the library binaries in the standalone_crt directory (matching the current TVM main), all the other files should be the same as I didn't change the standalone_crt file copy code.

thanks @alanmacd

[areusch]

@leandron can you explicit approve if you're good w/ this?

[mehrdadh]

Given the time that this PR was open I will merge it.
@leandron @areusch thanks for the reviews!