[BugFix] Pylance emits the warnning 'Code is unreachable' #13673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the code below the function calls tvm.ir.load_json/save_json.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
lightzhan-intellif
changed the title
wrongtest-intellif
approved these changes
Dec 30, 2022
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
Fix the issue that pylance emits the warnning 'Code is unreachable' for the code below the function calls tvm.ir.load_json/save_json. Co-authored-by: lightzhan-intellif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the users who use vscode to write code, Pylance in vscode will shadow the code below the function calls
tvm.ir.load_json/save_jsonand tell users "Code is unreachable" like the picture below:The issue maybe confuses users and make the code a little "dirty".
This PR fixes this by adding a return type hint to the functions
load_jsonandsave_json.