[TOPI] Fix tuple unpack in conv2d NCHWc int8 #13761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
michalpiszczek
changed the title
|
cc @jwfromm |
|
@tvm-bot rerun |
|
I know it's a miniature PR, but https://tvm.apache.org/docs/contribute/pull_request.html#commit-message-guideline |
michalpiszczek
changed the title
|
@tvm-bot rerun |
|
Looks like this needs to be linted. I think its also worth throwing in a comment explaining this explicit unpacking helps improve flexibility with other incoming layouts. |
jwfromm
approved these changes
Jan 11, 2023
|
@tvm-bot rerun |
1 similar comment
|
@tvm-bot rerun |
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
Fixes a tuple being incorrectly unpacked (too many elements expected) in a Conv2D TOPI int8 op, similarly to apache#13566 which addressed the issue specifically in the ARM implementation (which calls the function modified in this PR). This explicit unpacking helps improve flexibility with other incoming layouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a tuple being incorrectly unpacked (too many elements expected) in a Conv2D TOPI int8 op, similarly to #13566 which addressed the issue specifically in the ARM implementation (which calls the function modified in this PR).
This explicit unpacking helps improve flexibility with other incoming layouts.