Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend] Span Filling ONNX #13767

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

chunit-quic
Copy link
Contributor

  • Set node name as the source name of span during the conversion of ONNX model.
  • Assign node name to a node based on op type when it is empty.
  • To get the reference of renamed nodes. Add a function to export the ONNX model after conversion.
  • Add structural_equal comparisons with and without set_span to the existing test cases.
  • Add span test cases for frequent conversions.
  • Add span test case for exporting model parameter.

- Set node name as the source name of span during the conversion of
  ONNX model.
- Assign node name to a node based on op type when it is empty.
- To get the reference of renamed nodes. Add a function to export
  the ONNX model after conversion.
- Add structural_equal comparisons with and without set_span to the
  existing test cases.
- Add span test cases for frequent conversions.
- Add span test case for exporting model parameter.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 12, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: relay, frontend See #10317 for details

Generated by tvm-bot

@chunit-quic
Copy link
Contributor Author

Hi community,

This is a part of the RFC, TVM Explorer Infrastructure. After this PR, the source node information of ONNX will be tagged to the converted relay.
Note that the node names might not exist in the some model. Therefore we did the following changes for span mapping:

  1. Assign new node names based on their op types when they are missing during the conversion.
  2. Add a parameter to from_ONNX to export the model after the conversion.

Node names of the exported model can be a reference to the source_names of spans. Feel free to give us any comment. Thank you! :D

For your reference, here is the related links.
PreRFC in forum
apache/tvm-rfcs#92
#13116
@haowhsu-quic, @zack-ch

@masahi masahi merged commit 079876e into apache:main Jan 12, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
- Set node name as the source name of span during the conversion of
  ONNX model.
- Assign node name to a node based on op type when it is empty.
- To get the reference of renamed nodes. Add a function to export
  the ONNX model after conversion.
- Add structural_equal comparisons with and without set_span to the
  existing test cases.
- Add span test cases for frequent conversions.
- Add span test case for exporting model parameter.

Co-authored-by: Joey Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants