[Metaschedule] get_top_k should not return not built records #13824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
echuraev
approved these changes
Jan 23, 2023
| if (!run_secs.defined() || run_secs.value().empty() || | ||
| std::all_of(run_secs.value().begin(), run_secs.value().end(), | ||
| // 1e10 is used as a stub for undefined measurement times. | ||
| [](tvm::FloatImm v) { return v.defined() && v->value == 1e10; })) { |
There was a problem hiding this comment.
Probably we can define this constant in some common place and reuse it here and in other places?
E.g. as it was done here.
There was a problem hiding this comment.
I thought about using SortTuningRecordByMeanRunSecs, but memory_database is not sorted unlike json_database.
This constant appears in all tuners and unfortunately there is no common definition for it.
I can suggest to make an NFC patch with refactoring this constant throughout the repository.
masahi
approved these changes
Jan 24, 2023
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
…13824) * [Metaschedule] get_top_k should not return not built records * [Metaschedule][NFC] GetTopK extra polishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the situation when the records have measurements equal to 1e10, which is used as a stub for an indefinite measurement time, for example, when forming a cost models of the meta scheduler. The result of this will be extracting a record(that fails while building) as the best and an error in applying the tuning.