[DOCS][ADRENO] Improved Adreno documentation #13867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkreddy1238
force-pushed
the
adreno_documentation
branch
4 times, most recently
from
c14b573 to
772ce6f
Compare
Unified single documentation for all types of usage with OpenCL as well as CLML backends. Detailed simplified usage (with docker environment and command line tools like tvmc) as well as advanced usage instructions via python based interface.
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
772ce6f to
0e05122
Compare
echuraev
reviewed
Feb 1, 2023
Co-authored-by: Egor Churaev <[email protected]>
Co-authored-by: Egor Churaev <[email protected]>
srkreddy1238
force-pushed
the
adreno_documentation
branch
2 times, most recently
from
3502ccf to
a43658d
Compare
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
a43658d to
d4c1c7c
Compare
srkreddy1238
commented
Feb 13, 2023
srkreddy1238
force-pushed
the
adreno_documentation
branch
3 times, most recently
from
4c24470 to
2cdf5fe
Compare
echuraev
reviewed
Feb 14, 2023
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
2cdf5fe to
3f9609b
Compare
Co-authored-by: Egor Churaev <[email protected]>
Co-authored-by: Egor Churaev <[email protected]>
elvin-n
suggested changes
Feb 14, 2023
srkreddy1238
force-pushed
the
adreno_documentation
branch
2 times, most recently
from
49b4bbb to
caec976
Compare
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
caec976 to
ad82f8c
Compare
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
f3ea881 to
b2bb23b
Compare
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
9fe4cb8 to
5b9b1f2
Compare
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
5b9b1f2 to
f6e9a4d
Compare
Co-authored-by: Egor Churaev <[email protected]>
Co-authored-by: Egor Churaev <[email protected]>
echuraev
requested changes
Mar 10, 2023
echuraev
reviewed
Mar 14, 2023
| "app") | ||
| def_environment | ||
| echo "Setting dev environment with Tracker Port : $TVM_TRACKER_HOST} and the available devices are" | ||
| python3 -m tvm.exec.query_rpc_tracker --port ${TVM_TRACKER_PORT} |
There was a problem hiding this comment.
As far as I understood, the app mode is only for printing the list of the available devices (just call query), am I right?
Probably we should rename this mode to query? And you didn't describe this mode in the documentation. Could you please add it?
There was a problem hiding this comment.
Its sets the pytest and python environments.
srkreddy1238
force-pushed
the
adreno_documentation
branch
from
340caef to
908d8e0
Compare
echuraev
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
LGTM. Thank you @srkreddy1238 for hard working on this PR. The final result looks incredible. Hope it will be very helpful for new users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified single documentation for all types of usage with OpenCL as well as CLML backends.
Detailed simplified usage (with docker environment and command line tools like tvmc) as well as advanced usage instructions via python based interface.