Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] Added tests in test_forward_linear #13937

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

padreofthegame
Copy link
Contributor

Since the fixes in matmul operator are merged, this PR should complete the coverage of test cases for torch.nn.functional.linear function marked as TODO in test_forward.py file:

TODO: Add the following cases when matmul(1D, _) is supported by TVM

  • 1D input, 2D weight, 1D bias
  • 1D input, 2D weight, no bias
  • 1D input, 1D weight, scalar bias
  • 1D input, 1D weight, no bias

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 9, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link

@shingjan shingjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @masahi

@masahi
Copy link
Member

masahi commented Feb 10, 2023

@tvm-bot rerun

@masahi masahi merged commit 6f0e2ed into apache:main Feb 10, 2023
@padreofthegame padreofthegame deleted the pytorch/test_forward_linear branch February 10, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants