Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVMScript][Fix] Print Multi-line String as Metadata #13965

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

junrushao
Copy link
Member

Multi-line strings might make less sense to be printed out by default, as they could be LLVM snippets, CUDA source code and anything hard to comprehend but easy to mess up with the TVMScript itself. Therefore, this PR is introduced to print them as metadata by default.

Multi-line strings might make less sense to be printed out by default,
as they could be LLVM snippets, CUDA source code and anything hard to
comprehend but easy to mess up with the TVMScript itself. Therefore,
this PR is introduced to print them as metadata by default.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 12, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@junrushao junrushao marked this pull request as ready for review February 12, 2023 08:23
@junrushao
Copy link
Member Author

@junrushao
Copy link
Member Author

The unittest below has been testing this case:

tests/python/unittest/test_tvmscript_roundtrip.py::test_roundtrip[string_annotation_escaping]

@tqchen
Copy link
Member

tqchen commented Feb 12, 2023

Thanks @junrushao , i would even count this as a bugfix, since multi-line string printing would results in script that cannot be parsed

@tqchen tqchen changed the title [TVMScript] Print Multi-line String as Metadata [TVMScript][Fix] Print Multi-line String as Metadata Feb 12, 2023
@tqchen tqchen merged commit 09f38ac into apache:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants