Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Make T.prim_func typecheck as staticmethod #13980

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Feb 14, 2023

This PR makes T.prim_func typecheck as static method to reduce the set of warnings in tvmscript.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 14, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: ux See #10317 for details

Generated by tvm-bot

This PR makes T.prim_func typecheck as static method to reduce
the set of warnings in tvmscript.
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
Copy link
Member Author

tqchen commented Feb 14, 2023

@tvm-bot rerun

@MasterJH5574 MasterJH5574 merged commit c6ce283 into apache:main Feb 14, 2023
@tqchen tqchen deleted the script branch February 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants