[FIX][RUNTIME] Convert container with function value type #14024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
tqchen
approved these changes
Feb 17, 2023
Prior to this PR, though the `convert` function is capable of converting a single Python function/lambda to TVM func, it is not able to convert a container whose values inside are functions to TVM object. This PR adds function conversion to `convert_to_object` and redirects `convert` to `convert_to_object`, so that now the conversion is always recursive, and therefore will work well on function container value type. Co-authored-by: Chaofan Lin <[email protected]>
MasterJH5574
force-pushed
the
tvm-dev/2023-02-17-dict-func-conversion
branch
from
732c19c to
ff1647d
Compare
SiriusNEO
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, though the
convertfunction is capable of converting a single Python function/lambda to TVM func, it is not able to convert a container whose values inside are functions to TVM object.This PR adds function conversion to
convert_to_objectand redirectsconverttoconvert_to_object, so that now the conversion is always recursive, and therefore will work well on function container value type.Co-authored-by: Chaofan Lin [email protected]