-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoScheduler][AutoTVM] Enable xgboost >= 1.7.x new changes #14036
Conversation
thanks @cbalint13 can you make the xgboost be compatible to both APIs and send in the xgboost change in? This way we do not have to block on ci update |
@tqchen , Sure, lets make it compatible with anything xgboost>=1.1.0 up to latest 1.7.4 (as of this date). |
The android error is not related to this PR. Because check is not dependent on this, i can merge after other CI becomes green |
Saw the approval a bit late, meanwhile I just re-pushed PR (very same code, no changes). To sum the current state:
I stop right here unless explicit code change is requested. Thanks, |
I noticed similar flakiness on Android earlier today, which is unlikely relevant to your change. Don’t worry about it. We will merge it in ASAP |
Thanks @cbalint13 |
All credits goes to @Sunny-Island |
…14036) Enable xgboost >= 1.7.x new changes
This PR enables tvm to work with newer xgboost >= 1.7.x
Tested with booth AutoTVM and AutoSchedule.
All credits goes to @Sunny-Island
Thanks Jiabei !
Cc @Sunny-Island , @zxybazh @junrushao
also Cc @driazati for CI xgboost>=1.7.x changes
Thanks,
~Cristian.