[TVMScript] Distinguish LetStmt and Let expression #14207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the legacy behavior of previous generation of TVMScript printer, LetStmt and Let expression in TIR are printed in the same syntax, i.e.
T.let
. This could be confusing and misleading at times.This PR introduces a new printer behavior in a backward compatible way. While ensuring all legacy
T.let
can be parsed properly, we introduce different syntax for each of them.For LetStmt in TIR without concise scoping, the new syntax is:
which was:
For let expression in TIR PrimExpr, the new syntax becomes:
which was: