Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVMScript] Distinguish LetStmt and Let expression #14207

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

junrushao
Copy link
Member

As the legacy behavior of previous generation of TVMScript printer, LetStmt and Let expression in TIR are printed in the same syntax, i.e. T.let. This could be confusing and misleading at times.

This PR introduces a new printer behavior in a backward compatible way. While ensuring all legacy T.let can be parsed properly, we introduce different syntax for each of them.

For LetStmt in TIR without concise scoping, the new syntax is:

with T.LetStmt(value) as var:
  ...

which was:

var = T.int32()
with T.let(var, value):
  ...

For let expression in TIR PrimExpr, the new syntax becomes:

x = T.int32()
T.Let(x + 1, where={x : 1})

which was:

x = T.int32()
T.let(x, 1, x + 1)

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@junrushao junrushao force-pushed the feature/2023-03-05/printer-tir-let branch 2 times, most recently from 167e7d7 to db4bc0b Compare March 6, 2023 05:09
As the legacy behavior of previous generation of TVMScript printer,
LetStmt and Let expression in TIR are printed in the same syntax, i.e.
`T.let`. This could be confusing and misleading at times.

This PR introduces a new printer behavior in a backward compatible way.
While ensuring all legacy `T.let` can be parsed properly, we introduce
different syntax for each of them.

For LetStmt in TIR without concise scoping, the new syntax is:

```python
with T.LetStmt(value) as var:
  ...
```

which was:

```python
var = T.int32()
with T.let(var, value):
  ...
```

For let expression in TIR PrimExpr, the new syntax becomes:

```python
x = T.int32()
T.Let(x + 1, where={x : 1})
```

which was:

```python
x = T.int32()
T.let(x, 1, x + 1)
```
@junrushao junrushao force-pushed the feature/2023-03-05/printer-tir-let branch from db4bc0b to 488eaed Compare March 6, 2023 07:24
@junrushao junrushao marked this pull request as ready for review March 6, 2023 16:56
@zxybazh zxybazh merged commit e1c2ad1 into apache:main Mar 6, 2023
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Mar 16, 2023
When the TVMScript parser generates a `tir::LetStmt` to represent
assignment to a variable, the name of the variable should be used as
the name of the `tir::Var` in the `tir::LetStmt`.

This bug was introduced in apache#14207.
junrushao pushed a commit that referenced this pull request Mar 17, 2023
When the TVMScript parser generates a `tir::LetStmt` to represent
assignment to a variable, the name of the variable should be used as
the name of the `tir::Var` in the `tir::LetStmt`.

This bug was introduced in #14207.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants