[Transform] Use callable() instead of isinstance() for type checking #14248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, type-checking of a callable arguments, such as to `tvm.ir.transform.module_pass`, was done using `isinstance(arg, (types.FunctionType, types.LambdaType))`. This check can give false negatives for valid python types, such as a bound method or an instance of a class that implements `__call__`. This commit replaces the checks with the builtin function `callable()`, which handles any Python object that can be called using function-like syntax.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, type-checking of a callable arguments, such as to
tvm.ir.transform.module_pass, was done usingisinstance(arg, (types.FunctionType, types.LambdaType)). This check can give false negatives for valid python types, such as a bound method or an instance of a class that implements__call__.This commit replaces the checks with the builtin function
callable(), which handles any Python object that can be called using function-like syntax.