Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODEGEN][METAL] Fix ramp codegen #14330

Merged
merged 1 commit into from
Mar 19, 2023
Merged

[CODEGEN][METAL] Fix ramp codegen #14330

merged 1 commit into from
Mar 19, 2023

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Mar 19, 2023

Fix ramp node codegen for the metal backend.
The default C codegen can cause problem in
vector indices assignment.

Fix ramp node codegen for the metal backend.
The default C codegen can cause problem in
vector indices assignment.

Confirmed on apple M2.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 19, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@tqchen
Copy link
Member Author

tqchen commented Mar 19, 2023

currently ci do not support metal, confirmed on apple M2 for some cases that works on cuda,

Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM. And I don't want to block this PR by the comment, but I have one question: will it lake a long time to add a test for this change? If not, then I could run this test on my x86 Mac and check if it works here as well.
I don't think that it should take a lot of time for adding such test, because metal codegen test exists in the TVM.

@junrushao
Copy link
Member

Agree with @echuraev that we might need a unittest. @tqchen @MasterJH5574 would you like to follow up with a new PR? Thanks a lot!

@junrushao junrushao merged commit a5ed21d into apache:main Mar 19, 2023
@tqchen
Copy link
Member Author

tqchen commented Mar 19, 2023

Thanks @echuraev . we will send in a test in a followup

@tqchen
Copy link
Member Author

tqchen commented Mar 19, 2023

#14331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants