-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOPI] Fix data race of batch multibox detection #14343
[TOPI] Fix data race of batch multibox detection #14343
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
@tvm-bot rerun |
cc @kevinthesun @Laurawly @tqchen Hi~ could you kindly take a look at it, thanks! |
cc @masahi , can you help to take a look at this? |
box_coord[l] = anchor[0, j, l] | ||
pred_coord[l] = loc_pred[i, j * 4 + l] | ||
out_coord = _hybridy_transform_loc(box_coord, pred_coord, variances, clip) | ||
box_coord[i, l] = anchor[0, j, l] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems box_coord
is the same in all threads. How about passing anchor
, j
, and l
to _hybridy_transform_loc
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea~ updated as suggested.
Need to fix lint. |
@tvm-bot rerun |
1 similar comment
@tvm-bot rerun |
box_coord
andpred_coord
is shared across parallel batch like