[QNN] Convert fake quantized take to quantized op #14506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just using the vanila
take
op should be fine. I referred to howpad
op is handled.Note this implementation works only for constant indices. To handle non constant indices, I'm guessing we should modify
src/relay/transforms/fake_quantization_to_integer.cc
so that it allows integer inputs without dequantize. Specifically, I think it should capture the following pattern:but I'm not 100% sure.