Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN] Convert fake quantized take to quantized op #14506

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

shinh
Copy link
Contributor

@shinh shinh commented Apr 5, 2023

Just using the vanila take op should be fine. I referred to how pad op is handled.

Note this implementation works only for constant indices. To handle non constant indices, I'm guessing we should modify src/relay/transforms/fake_quantization_to_integer.cc so that it allows integer inputs without dequantize. Specifically, I think it should capture the following pattern:

x  i
|  |
dq |
|  |
\  /
take
 |
 q

but I'm not 100% sure.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 5, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@masahi masahi merged commit fd7e364 into apache:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants