[TVMScript] Preserve LetStmt of constants #14531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `bind_assign_value` implementation for TIR would treat assignment of constants (e.g. `j = 42`) as meta-variables to be inserted at their point of use. This commit updates the parsing to treat `j = 42` as a shorthand for the TIR `LetStmt`, similar to the update made in apache#14320. This behavior is more consistent with the other uses of `bind_assign_value` as assignment, with `j = T.meta_var(42)` used to represent meta-variables.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
The change makes sense to me! Originally we had to take care of this only for 100% backward compatibility reasons, but in fact this behavior is much better in terms of consistency. CC @wrongtest-intellif let me know what you think given you guys are heavily using TVMScript |
Lunderberg
changed the title
|
@junrushao That makes sense, especially when preparing the new parsing implementation to be a drop-in replacement for the older implementation. Thank you for pinging @wrongtest-intellif , and I've marked it as ready-for-review. |
tqchen
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
bind_assign_valueimplementation for TIR would treat assignment of constants (e.g.j = 42) as meta-variables to be inserted at their point of use. This commit updates the parsing to treatj = 42as a shorthand for the TIRLetStmt, similar to the update made in #14320. This behavior is more consistent with the other uses ofbind_assign_valueas assignment, withj = T.meta_var(42)used to represent meta-variables.