-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microNPU][ETHOSU] Fix SoftMax legalization parameters #15069
Merged
lhutton1
merged 4 commits into
apache:main
from
Aleksei-grovety:ethosu-fix-softmax-activation-parameters
Jun 26, 2023
Merged
[microNPU][ETHOSU] Fix SoftMax legalization parameters #15069
lhutton1
merged 4 commits into
apache:main
from
Aleksei-grovety:ethosu-fix-softmax-activation-parameters
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekalda
reviewed
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Aleksei-grovety! I'm wondering if there could be a test included that exercises this change?
Aleksei-grovety
changed the title
[microNPU][ETHOSU] Fix Softmax activation parameters
[microNPU][ETHOSU] Fix SoftMax legalization parameters
Jun 20, 2023
I checked the output of the generated commands in TVM and Vela and updated legalization test accordingly. |
ekalda
reviewed
Jun 20, 2023
Fix activation parameters for operations according to the values in Vela.
Aleksei-grovety
force-pushed
the
ethosu-fix-softmax-activation-parameters
branch
from
June 23, 2023 13:34
91bc9ca
to
d55ebb0
Compare
@tvm-bot rerun |
lhutton1
approved these changes
Jun 26, 2023
Thanks @Aleksei-grovety @ekalda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SoftMax legalization parameters according to the values in Vela.
cc @neildhickey, @lhutton1, @ekalda, @leandron