Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU][ETHOSU] Fix minimum buffer size #15104

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

Aleksei-grovety
Copy link
Contributor

Fix minimum buffer size for DMA operations according to alignment.

cc @neildhickey, @lhutton1, @ekalda, @leandron

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 15, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Fix minimum buffer size for DMA operations according to alignment.
@Aleksei-grovety Aleksei-grovety force-pushed the ethosu-fix-min-buffer-size branch from 5345541 to b8d6641 Compare June 16, 2023 06:55
Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aleksei-grovety! I think a test would be good there as well.

@Aleksei-grovety
Copy link
Contributor Author

I added a test for this case.

Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Aleksei-grovety!

@ekalda ekalda merged commit 31be726 into apache:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants