Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR][BugFix]Ensure the Var's scope is correct #15406

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

sisleyli
Copy link
Contributor

In the previous bf16legalize pass, the storage_scope of the original BufferVar was not retained, but all changed to the default value (global). The purpose of this PR is to ensure that Var's scope is always correct

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 25, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@sisleyli
Copy link
Contributor Author

Hi @junrushao @masahi , could you help me review this PR? Thank you!

@sisleyli sisleyli changed the title [TIR][BugFix]Ensure Var's scope is correct [TIR][BugFix]Ensure the Var's scope is correct Jul 25, 2023
Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new testcases instead of changing the existing ones

@sisleyli
Copy link
Contributor Author

@Hzfengsy Done. Please take another look, thank you.

@sisleyli
Copy link
Contributor Author

@tvm-bot rerun

@sisleyli
Copy link
Contributor Author

this PR has passed CI, could you please help me merge it? Thanks @Hzfengsy

@Hzfengsy Hzfengsy merged commit d9c2b9c into apache:main Jul 28, 2023
@Hzfengsy
Copy link
Member

Thanks @sisleyli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants